Lyrics ,Music:Larry Shay, Mark Fisher, Joe Goodwin
The song was publishe 1928.
Many other recordings exist, for example those by Billie Holiday with Lester Young and Teddy Wilson in 1938, Studies in Swing No.3, Louis Prima, Frank Sinatra, Julia Lee, Nat King Cole and Patti Page. Cliff Bruner brought it to the country charts in 1939. It was adopted by Leicester City F.C. as the club anthem, and can be heard at many of the team's games. In 1961, Judy Garland performed the song at the Judy at Carnegie Hall concert. Andy Williams released a version on his 1963 album, Days of Wine and Roses and Other TV Requests. Dean Martin also sang it, sometimes parodying it as "When You're Drinkin'". Teddy Wilson & His Orchestra, with Billie Holiday, performed this classic on January 6, 1938, in New York City for Brunswick/Columbia, with Teddy Wilson on piano, Benny Morton on trombone, Buck Clayton on trumpet, Lester Young on tenor sax, Freddie Green on guitar, Walter Page on bass and Jo Jones on drums.
When you're smiling When you're smiling The whole world smiles with you
When you're laughing When you're laughing The sun comes shining through
But when you're crying You bring on the rain So stop that sighing Be happy again
Keep on smiling Cause when you're smiling The whole world smiles with you